Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize creation of Chat collection view layout models #741

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jrcmramos-bumble
Copy link
Collaborator

This PR decouples the adapter from the creation of collection items diff.
Since this operation can take some time, this could block the release of ChatMessageCollectionAdapter, since it was retaining it.

@gsherofly007
Copy link

gsherofly007 commented Jan 6, 2022 via email

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #741 (58fba30) into master (1f4f9a7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 58fba30 differs from pull request most recent head 70cb421. Consider uploading reports for the commit 70cb421 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
+ Coverage   54.84%   54.86%   +0.01%     
==========================================
  Files         108      110       +2     
  Lines        5745     5760      +15     
==========================================
+ Hits         3151     3160       +9     
- Misses       2594     2600       +6     
Impacted Files Coverage Δ
...oller/ChatMessages/ChatCollectionItemsDiffer.swift 100.00% <100.00%> (ø)
...essages/ChatCollectionViewLayoutModelFactory.swift 100.00% <100.00%> (ø)
...er/ChatMessages/ChatMessageCollectionAdapter.swift 78.12% <100.00%> (-2.96%) ⬇️
...Chat Items/TextMessages/Views/TextBubbleView.swift 82.44% <0.00%> (-3.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4f9a7...70cb421. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants