Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bitManna Finality Provider #326

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Add bitManna Finality Provider #326

merged 2 commits into from
Aug 20, 2024

Conversation

Jason2d2
Copy link
Contributor

@Jason2d2 Jason2d2 commented Aug 16, 2024

New bitManna Finality Provider

Checklist

Caution

The loss of the (generated keys + mnemonic) makes the finality provider
useless and unable to provide finality, which would lead to no transition to
later phases of the Babylon network.

@Jason2d2 Jason2d2 changed the title Add bitManna registration Add bitManna Finality Provider Aug 16, 2024
Copy link
Collaborator

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@RafilxTenfen RafilxTenfen requested review from a team, vitsalis, filippos47 and RafilxTenfen and removed request for a team, vitsalis and filippos47 August 16, 2024 21:23
@RafilxTenfen
Copy link
Collaborator

Hey @Jason2d2, the user @bitManna should be the one that submits the PR
Can you verify?

@Jason2d2
Copy link
Contributor Author

Jason2d2 commented Aug 17, 2024

@RafilxTenfen - I was unable to to fork with @bitManna, and created an Issue. I also opened a support ticket with gitHub. However, @Jason2d2 was able to fork. I managed the PR with @Jason2d2. I also attempted to update the KYB on Synaps with the @Jason2d2 handle to match the PR.

@bitManna
Copy link

bitManna commented Aug 17, 2024

@RafilxTenfen - I am adding a comment from the @bitManna account for verification sake. I am unable to perform the Fork with @bitManna do to some constraint, of which I have a support ticket in with gitHub, and an Issue created on the babylon repo. I used @Jason2d2 for the sake of time.

@RafilxTenfen
Copy link
Collaborator

Can you comment with @bitManna user approving @Jason2d2 to submit the PR on your behalf?

@bitManna
Copy link

bitManna commented Aug 19, 2024 via email

@Jason2d2
Copy link
Contributor Author

@RafilxTenfen

@Jason2d2 submitted PR 326 https://github.com/babylonlabs-io/networks/pull/326on behalf of @bitManna due to a GitHub issue which we have submitted a ticket for.
I have also submitted an issue on Babylon stating the case: #324

I have posted a comment as @bitManna to the PR here #326 (comment)
Oddly enough, I only see the @bitManna comment showing on the PR, when I view it as @bitManna. There must be some account issue to be corrected by GitHub support.

I have also posted the issue on our website, www.bitmanna.com, scroll to the Babylon section.

I have also sent an email to your gmail from the bitManna email.

@RafilxTenfen
Copy link
Collaborator

can you make the user @bitManna public available?

@Jason2d2
Copy link
Contributor Author

Jason2d2 commented Aug 19, 2024

can you make the user @bitManna public available?

@RafilxTenfen - It is public, it is just being hidden due to some account issue. There is something up with GitHub, and they have not corrected the issue as of yet. I added the PR to the www.bitmanna.com website, under the babylon section. I have also tweeted the same message from the bitManna twitter: https://x.com/bitManna_/status/1825601816220020883

Thank you for working with us, this is the worst timing as you are nearing launch.

I tried to redo the KYB and attach to @Jason2d2, but I am unsure if you can see that update.

@bitManna
Copy link

bitManna commented Aug 19, 2024

testing

@RafilxTenfen
Copy link
Collaborator

Hey @Jason2d2, can you send an email to "[email protected]" explaining your situation

@Jason2d2
Copy link
Contributor Author

Hey @Jason2d2, can you send an email to "[email protected]" explaining your situation

I just sent the details. Thank you.

Copy link
Collaborator

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@RafilxTenfen RafilxTenfen requested review from a team, vitsalis and filippos47 August 20, 2024 16:59
@vitsalis vitsalis merged commit 4dc0fd9 into babylonlabs-io:main Aug 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants