Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preAnnounceSeconds check #13

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Conversation

garfieldbanks
Copy link
Contributor

Fixes #10

@pangolp
Copy link
Contributor

pangolp commented Feb 3, 2024

The repository is outdated. I'm going to make some changes and when it's updated, if you update your branch with the new changes, we can rerun the tests and in that way add the code to the repository

@pangolp
Copy link
Contributor

pangolp commented Feb 3, 2024

After this pull request passes the tests: #14 and the code can be merged, we can update this pull request, and run the tests again .

@pangolp
Copy link
Contributor

pangolp commented Feb 3, 2024

It would be necessary to update the branch, with the new changes within the module, to run the tests again. When you do, please let me know. Thank you.

@Helias Helias merged commit bb72228 into azerothcore:master Feb 3, 2024
1 check passed
@Helias
Copy link
Member

Helias commented Feb 3, 2024

thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG
3 participants