Fix bug in Enchant Gloves for Engineering and add configuration option for special enchantments #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdikhody
changed the title
mehdikhody
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug related to the Enchant Gloves functionality for players with Engineering. Additionally, it introduces a new configuration option to enable or disable special enchantments, such as the "100 Attack Power + 36 Critical" enchant for the legs, which is typically only available to GMs.
The original code only allowed the "Hyperspeed Accelerators" enchantment for players with exactly 400 skill points in Engineering. The condition has been updated to allow the enchantment for players with 400 or more skill points in Engineering.