fix(Script/BlackTemple): teleport position with fatal attraction #19971
Conversation
|
TC/Mangos research point to it being random and not static |
|
With few videos, and a IG, the dist from the boss seems to not be always 48.0f. For the moment, I set a minimal value to 30.0f for tests but need to adjust with more research. But the PR can be tested. (Even if I tested myself, another confirmation is the well done. I never done this boss). |
|
I've not test the last commit, and I will not be able to test it before wednesday. |
|
|
||
| // Ensure that the destination is not too close to the caster. | ||
| // Add a check for LOS, to ensure to not be teleported under the map | ||
| while (!teleportDest.IsRadiusPositionValid(GetCaster(), teleportDest, 25.0f)) |
There was a problem hiding this comment.
I wouldn’t use this while loop here. It could result in an infinite loop or have unpredictable time complexity.
I don’t know much about this spell, but I assume it’s used by a single boss. If that’s the case, have you considered creating some safe rectangle(s) or circle(s) at the boss's location and simply finding a random point within the shape using a given radius?
There was a problem hiding this comment.
The boss can be tank in all the hall. So I can't create a specific area. I can also add a check to break the loop After a certain nomber of try. Otherwise I don't know how done this without "while loop" as we doesn't have specific waypoints.
There was a problem hiding this comment.
Why can't we use this rectangle area?
Or if looks not too good then maybe we can work with these 3 rectangles?
|
I tested the pr. It doesn't fix the teleport issue. I think that the original report author was right. It should be some type of black list where the boss is not able to teleport you.
In addition, after watching some gamplay videos, I think that boss couldn't teleport the players too near to the walls. An example of a safe area: |
|
I know. That why I tried to instore a radius object check before to teleport. But I think that I need to debug the process. |
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.