Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_NO_LOREMAST… #19962

Merged

Conversation

sudlud
Copy link
Member

@sudlud sudlud commented Sep 13, 2024

…ER_COUNT

  • this allows flagging quests so that they will not count towards Loremaster achievement
  • update Corrupted Flower Quests in Felwood accordingly as a first use case

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

…ER_COUNT

- this allows flagging quests so that they will not count towards Loremaster achievement
- update Corrupted Flower Quests in Felwood accordingly as a first use case
@sudlud sudlud added Waiting to be Tested Ready to be Reviewed Requires WIKI Update Wiki sources will need to be updated after merging this PR. labels Sep 13, 2024
@github-actions github-actions bot added DB related to the SQL database CORE Related to the core file-cpp Used to trigger the matrix build labels Sep 13, 2024
@sudlud
Copy link
Member Author

sudlud commented Sep 14, 2024

It looks like repeatable quests (with repeatable flag) should also be excluded in general from loremaster?

https://www.wowhead.com/wotlk/achievement=1681/the-loremaster#comments:id=384634

@TheSCREWEDSoftware
Copy link

What needs to be update on the wiki?

@sudlud
Copy link
Member Author

sudlud commented Sep 15, 2024

Adding the new flag to SpecialFlags on the wiki page of quest_template_addon, also must be added to keira3

@Nyeriah Nyeriah merged commit e2353a1 into azerothcore:master Sep 15, 2024
14 checks passed
@sudlud sudlud deleted the implement-quest-loremaster-ignore-flag-1 branch September 16, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core DB related to the SQL database file-cpp Used to trigger the matrix build Ready to be Reviewed Requires WIKI Update Wiki sources will need to be updated after merging this PR. Waiting to be Tested
Projects
None yet
4 participants