Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Creature) Ebon Blade Commander Equipment #19846

Merged
merged 4 commits into from
Sep 21, 2024

Conversation

jorge990125
Copy link
Contributor

@jorge990125 jorge990125 commented Sep 1, 2024

Changes Proposed:

This PR proposes changes to:

  • Database (SAI, creatures, etc).

Tests Performed:

This PR has been:

  • Tested in-game by the author.

How to Test the Changes:

  • import the sql to the database
  • start the server
  • enter icc

example of the solution
https://www.wowhead.com/wotlk/npc=37967/ebon-blade-commander
363520890-a1222331-78d8-4183-944f-e8548c68eb03

@github-actions github-actions bot added the DB related to the SQL database label Sep 1, 2024
@elthehablo
Copy link
Contributor

I'm unsure exactly what you're doing here, but if you're only updating equipment, it's best to do an update instead of an insert

@jorge990125
Copy link
Contributor Author

I only added the equipment to the npc that did not have it on, if you want go to icc and see for yourself

@avarishd
Copy link
Contributor

avarishd commented Sep 3, 2024

UPDATE instead of INSERT, for equipment_id.
https://www.azerothcore.org/wiki/sql-standards#update

@elthehablo
Copy link
Contributor

I only added the equipment to the npc that did not have it on, if you want go to icc and see for yourself

Okay that is great. Then it's better to do an update statement. I will show you why. This is current guid 88752 on live:

(88752, 37967, 0, 0, 571, 0, 0, 1, 1, 0, 5606.21, 2012.55, 798.125, 0.994737, 120, 0, 0, 1, 0, 0, 0, 0, 0, '', 0)

Your change is:

(88752, 37967, 0, 0, 571, 0, 0, 1, 1, 1, 5606.21, 2012.55, 798.125, 0.994838, 120, 0, 0, 1, 0, 0, 0, 0, 0, '', 0)

So it looks like you are slightly changing the position. What is that based on? It does not show from the PR. But if you're not changing the position you can just do an UPDATE on the equipment_id for the valid creatures

@jorge990125 jorge990125 closed this Sep 3, 2024
@jorge990125 jorge990125 reopened this Sep 3, 2024
@jorge990125
Copy link
Contributor Author

ahh I understand, I will make the change again only for equipment_id

@sudlud sudlud merged commit 1802de9 into azerothcore:master Sep 21, 2024
17 checks passed
@jorge990125 jorge990125 deleted the fix-ebon-blade branch September 22, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants