-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DB/Creature) Ebon Blade Commander Equipment #19846
Conversation
I'm unsure exactly what you're doing here, but if you're only updating equipment, it's best to do an update instead of an insert |
I only added the equipment to the npc that did not have it on, if you want go to icc and see for yourself |
UPDATE instead of INSERT, for |
Okay that is great. Then it's better to do an update statement. I will show you why. This is current guid 88752 on live: (88752, 37967, 0, 0, 571, 0, 0, 1, 1, 0, 5606.21, 2012.55, 798.125, 0.994737, 120, 0, 0, 1, 0, 0, 0, 0, 0, '', 0) Your change is: (88752, 37967, 0, 0, 571, 0, 0, 1, 1, 1, 5606.21, 2012.55, 798.125, 0.994838, 120, 0, 0, 1, 0, 0, 0, 0, 0, '', 0) So it looks like you are slightly changing the position. What is that based on? It does not show from the PR. But if you're not changing the position you can just do an UPDATE on the equipment_id for the valid creatures |
ahh I understand, I will make the change again only for equipment_id |
Changes Proposed:
This PR proposes changes to:
Tests Performed:
This PR has been:
How to Test the Changes:
example of the solution
https://www.wowhead.com/wotlk/npc=37967/ebon-blade-commander