Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/quest_offer_reward): C'Thun's Legacy turnin dialogue #19130

Merged

Conversation

proxical
Copy link
Contributor

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

Fixes quest turn-in dialogue not respecting character gender and always using Lady instead of Lady/Lord which reflects an oversight in the original dialogue that does not exist on live servers
before-fix-aq40d

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.
  • [ ]
    Tested in-game on Windows and verified to build without errors. Dialogue was viewed as both a male and a female to verify functionality and quest was completed without issue with correct dialogue as shown below in images. No other issues caused by this change.
    image
    image

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. .additem 21221
  2. Clear AQ40 and proceed to Caelestrasz
  3. Verify that on turning in the quest your character receives the correct dialogue

Known Issues and TODO List:

This change fully fixes the issue and there is no more to be done to resolve this issue.

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB related to the SQL database label Jun 23, 2024
@@ -0,0 +1,2 @@
--
UPDATE `quest_offer_reward` SET `RewardText`='We will leave this place on our own, $G Lord:Lady; $N - once we are certain that the evil within has been wholly destroyed. Your journey of legend is almost at an end.' WHERE `ID`=8801;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please zero out the VerifiedBuild value.

@sudlud
Copy link
Member

sudlud commented Sep 21, 2024

thanks for the PR!

please address the latest review and also there's actually another line in this quest dialogue affected:

quest_request_items.sql: (8801, 68, 0, 'Lady $N, you have freed us of its grasp.', 12340),

can you please also update this one?


  • test steps
.additem 21221
.quest complete 8801
.go c id 15379

@proxical
Copy link
Contributor Author

proxical commented Sep 22, 2024

Review addressed in latest commit that set VerifiedBuild value to 0. Second quest dialogue line fixed as well in the latest revision. Tested the changes using attached instructions above and confirmed that both dialogue pieces are now working.
Screenshot 2024-09-21 172723
Screenshot 2024-09-21 172731

@sudlud sudlud merged commit 44a10e7 into azerothcore:master Sep 22, 2024
17 checks passed
@sudlud sudlud added the Tested This PR has been tested and is working. label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database Tested This PR has been tested and is working. To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants