Fix(DB): Loot Adamantite Ore

[The-GhostRider]

Changes Proposed:

I noticed that a small calculation error was made.
the Error was not due to loot %, but to a missing reference.
In essence, (I don't know if due to inaccuracy or laziness), a double reference was made in reference to the fact that a gem must always be guaranteed. (See screenshot below).

Wrong Reference

Consequently, this double reference led to a double loot with MaxCount "2", one given at 100% chance and the other given at 15% chance, giving rise to an "alteration" of the loot %. (See screenshots below).

Test 1 of 1000 Adamantite (Wrong Loot)

Test 2 of 1000 Adamantite (Wrong Loot)

Test 3 of 1000 Adamantite (Wrong Loot)

So I created an appropriate reference for guaranteed gems. (See screenshot below).

Fixed Reference

In fact, with this change, the loot now comes close to the expectations of the sources cited below

Test 1 of 1000 Adamantite (Fixed Loot)

Test 2 of 1000 Adamantite (Fixed Loot)

Test 3 of 1000 Adamantite (Fixed Loot)

These are the percentages and the tests I did.

Test Percentages

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes Prospecting Adamantite Ore yields too many uncommon gems chromiecraft/chromiecraft#4749
• Closes Prospecting Adamantite Ore yields too many uncommon gems #17922

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  -- Prospecting Adamantite Ore yields unexpected results #14441
  -- https://www.youtube.com/watch?v=T0dDBoU0zF0&t=95s
  -- https://www.youtube.com/watch?v=F2IM025ZL6s&t=707s
  -- Prospecting Adamantite Ore yields too many uncommon gems chromiecraft/chromiecraft#4749 (comment)

• Sniffs (remember to share them with the open source community!)

• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)

• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

.learn all recipes jewelcrafting
.additem 23425 1000

macro:

/cast Prospecting
/use Adamantite Ore

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[balleny]

the same fix with the same but halfed rates for rare gems could be applied to fel iron ore to close pending tickets.

[pangolp]

What status is this pull request in?