fix Riding Speed increases Druid Flight Forms

[grimgravy]

Changes Proposed:

• added modification made at TBC

Issues Addressed:

• Closes Riding Speed increases affecting Druid Flight Forms #16235

SOURCE:

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Annamaria-CC]

testing in progress

tested
Flight Form

• Skybreakers whip works on flightform
• enchants gloves, mithril spurs and carrot on a stick don't work on flight form

Normal mount

• Skybreakers whip works on normal mount
• Enchant gloves, mithril spurs and carrot on a stick stack on top of eachother, gaining the same +10% mount speed as with a whip. Not sure if intended.

Please review and tell me if this is correct behaviour or not

[Tereneckla]

Yes, enchant, spurs and carrot should stack

[Annamaria-CC]

Yes, enchant, spurs and carrot should stack

corrected the above then <3

[Kitzunu]

Conflict

[sudlud]

Can you please resolve the conflicts again

[sudlud]

Thanks for the update!

I'm using Carbonite right now
https://felbite.com/addon/4846-carbonite/
to get a flight speed info within the client and tried to test this PR.

level 70 tauren druid in "swift flight form"
Riding Crop (features spell 48776)
.additem 25653

unequipped
speed: 280%

equipped
speed: 318%

If I understand correctly, the speed should be 280% even when "Riding Crop" is equipped?

Right now to me it looks like this PR does not have the desired effect, can you please check or give a hint what's going wrong on my side?

Thanks!

[grimgravy]

Thanks for the update!

I'm using Carbonite right now https://felbite.com/addon/4846-carbonite/ to get a flight speed info within the client and tried to test this PR.

level 70 tauren druid in "swift flight form" Riding Crop (features spell 48776) .additem 25653

unequipped speed: 280%

equipped speed: 318%

If I understand correctly, the speed should be 280% even when "Riding Crop" is equipped?

Right now to me it looks like this PR does not have the desired effect, can you please check or give a hint what's going wrong on my side?

Thanks!

The Riding Crop is working with or without changes. However, the carrot on a stick and mithril spurs need modification

Interesting fact: flying mount 305% and swift flight form 295%

[sudlud]

Looks like CI is broken right now

[sudlud]

So what's the state of this PR now? Ready to be tested again?

[Kitzunu]

Conflicts

[alecsci]

What's the status for this ? if it's not ready can we label it differently ?

[Nyeriah]

TBH I don't like DBC edits that edit effect types, aura types etc. Always feel like a big hack

[grimgravy]

the effect is affecting the speed of other flight assemblies. i don't know what to do

[sudlud]

There have been changes made in this PR forth and back but there's no real "this is it - please review and test" state in this PR.

I would suggest closing it for now. Please feel free to open a new PR if you've found a viable solution for this issue.

[sogladev]

When comparing Mithril Spurs 59916 (no bug) with Riding Crop 48383, the DBC effects differ which explains the bug. Imo the DBC is wrong, or the below is using the wrong effect spell, but I can't find one that gives 10% speed with effect SPELL_AURA_MOD_MOUNTED...SPEED

azerothcore-wotlk/src/server/scripts/Spells/spell_item.cpp

Line 228 in bb0d292

SPELL_RIDING_CROP_EFFECT = 48383,

items like carrot, mithril spurs
SPELL_AURA_MOD_MOUNTED_FLIGHT_SPEED_ALWAYS
SPELL_AURA_MOD_MOUNTED_SPEED_ALWAYS

non-stackable bonus like crusader aura and riding crop
SPELL_AURA_MOD_FLIGHT_SPEED_NOT_STACK
SPELL_AURA_MOD_MOUNTED_SPEED_NOT_STACK

relevant core, handling looks correct

azerothcore-wotlk/src/server/game/Entities/Unit/Unit.cpp

Line 14276 in bb0d292

else if (IsMounted())