-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CORE/OPvP): Halaa Mechanics not working properly #14428
Conversation
Fixes Halaa can be captured with all the guards alive azerothcore#14355 Valdifer
Could be this still WIP¿? |
After taking a look into this, OutdoorPvP global class its the called by all OutdoorPVPScripts, all of them override the Update Method, in that method all of them call the global Update from OutdoorPvP global class and get a bool returned, the thing is Halaa works "different". I mean, when all OutdoorPvP have to be updated every time one player is in the area in halaa there is 2 things:
Thats the thing i saw, if someone has a better idea or see another way tell me and i can take a look but now i tryed a lot of things to afford that and i need confirmation from official WoW.
If im wrong correct me or discuss im open to see what you think guys and thanks for let me fix the Halaa :D |
Fixed Dot Fire Bomb damage
The DOT Damage is fixed now I have to check official Blizzard because i saw there is 4 guards making patrols with waypoints. I made to work Halaa when u have captured it still progressing only the controller faction, but is working doing the thing i said above but i need to confirm that is working as i say. I need sniff the patrols to see how they patrol halaa and see the mechanics of halaa in official blizzard, if someone knows how it works or have a Clue would be awesome |
Yeah we can check waypoints no problem. @Valdifer , btw, interacting with the Roosts, even the destroyed ones, should flag players for PvP, is that a thing currently? Sorry I'm not up to speed with Halaa, I'll help with if I can here with research. The main problem I'm having is that the Classic PTR is down atm. |
Here's the waypoints:
|
I tested that in Retail but unfortunately forgot to record it. When it's not captured by anyone (after a server reset) the flag is NEUTRAL and must be FULLY CAPTURED. Only after it is fully captured that the guards will spawn. So after a server restart it's a free-for-all. And the flag happens when I click the roost (destroyed or not) |
It seems to me like the NPCs aren't spawned properly. A lot of them wander when they shouldn't. |
Thx for all that info Gultask, then that my friend told me is true, now i have an idea what to do, there is more things to fix i found (When you die all players spawn in Halaa GY when it should be only by Halaa owners) |
Let me know if you need anything else. I'm not very knowledgeable on PvP 😛 |
Thx 😃, right now im ok, i got this, you helped me a lot 😃, i'll finish when i come back to home |
Done capturing halaa when full bar, gonna test it to see if it works right now with both factions and after reset before upload |
Still need to clean some code from the global update, because i copied and adapted it to halaa mechanics and prolly there is some parts of code that are useless, and more test with the respawn guards |
I have been tested it and for now i didn't found any errors (Now seems to works more like blizzlike), the thing i still don't get is the waypoints, i have them thx to gultask but when i do: I think i got it, saw something in the code, tomorrow i check, i will continue posting updates |
Still WIP, not abandoned, just leveling a 80 in blizzard WoW, taking advantage 50% exp |
Feel free to mark the PR as a draft until it's ready, we can wait. 😉 |
Indicating is Fire Bomb from halaa
removed whitespaces
removed whitespaces (Still WIP because the mechanic of respawn it is not how it works in Blizz)
Ok, i tested waypoints but i have to test more the mobs because all of them are generated by a general method to add spawns to cell and there is no Waypoints using that method so i have to change some things to make guards do patrols |
Unfortunately I can't help there. I don't know much about the cpp part of the Core. |
Have a look at TrinityCore/TrinityCore@b5194a1 |
As far i saw the positions of them are correct except for 2 of them but i was taking a look and sniffing Halaa in blizzard and got all positions, positions are ok
I will test to see the difference between spellinfocorrection and that |
Tested now, debuff dissapear, with the spellinfocorrection works and the dot doesnt get debuffed after throw the bomb, before it was working ok. But thx to that i can add a SQL script to fix that spell and we can avoid the spellinfocorrection :) |
Still doing it, now i think got how to do it through DB and not use Hardcode NPCs (I want to avoid this cos through DB for me its better than insert the code in the classes) |
After some tests, rewriting logic, finally i made it working but i have now a new problem, there are 5 NPCS that didn't spawn and i got this into the console im removing creatures and updating the id1 data in code (SQL is not changed), server is working without problems but still getting that console error, dunno if that console msg is a problem Edit: Solved it, and the console errors too, finally working npcs patrolling, i have to do more tests, thx for the patience guys and sry, i had some thing to do and i delayed this |
I need some feedback to see if i have to change this coz using this options from worldserver.conf PreloadAllNonInstancedMapGrids = 1 The server is crashing, but the map that is crashing is 581 (Northrend), so 530 isn't crashing, anyway i need feedback to see if i should change this guys to something better (Like hardcode waypoints) |
I think im gonna open it in a new PR coz seems i did something wrong with the update with objmgr |
Here: #15634 |
Changes Proposed:
Issues Addressed:
SOURCE:
Tests Performed:
How to Test the Changes:
Known Issues and TODO List:
Bombs still not working properly making guards get the DOT]When there is no guards, can be fully captured only at max points]All dead players can spawn in Halaa when it should be by TEAM_CONTROLLER (Happens only when server is restarted)]Guards patrolling waypoints] PARTIALLY (Have to check why Vendors doesnt appear)Flags players when interact with Roosts]Capture area very big (Can be captured down the hill)]How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.