-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'azerothcore:master' into shandy-fix
- Loading branch information
Showing
559 changed files
with
6,821 additions
and
5,208 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,232 @@ | ||
| import io | ||
| import os | ||
| import sys | ||
| import re | ||
|
|
||
| # Get the src directory of the project | ||
| src_directory = os.path.join(os.getcwd(), 'src') | ||
|
|
||
| # Global variables | ||
| error_handler = False | ||
| results = { | ||
| "Multiple blank lines check": "Passed", | ||
| "Trailing whitespace check": "Passed", | ||
| "GetCounter() check": "Passed", | ||
| "Misc codestyle check": "Passed", | ||
| "GetTypeId() check": "Passed", | ||
| "NpcFlagHelpers check": "Passed", | ||
| "ItemFlagHelpers check": "Passed", | ||
| "ItemTemplateFlagHelpers check": "Passed" | ||
| } | ||
|
|
||
| # Main function to parse all the files of the project | ||
| def parsing_file(directory: str) -> None: | ||
| for root, _, files in os.walk(directory): | ||
| for file in files: | ||
| if not file.endswith('.ico'): # Skip .ico files that cannot be read | ||
| file_path = os.path.join(root, file) | ||
| file_name = file | ||
| try: | ||
| with open(file_path, 'r', encoding='utf-8') as file: | ||
| multiple_blank_lines_check(file, file_path) | ||
| trailing_whitespace_check(file, file_path) | ||
| get_counter_check(file, file_path) | ||
| misc_codestyle_check(file, file_path) | ||
| if file_name != 'Object.h': | ||
| get_typeid_check(file, file_path) | ||
| if file_name != 'Unit.h': | ||
| npcflags_helpers_check(file, file_path) | ||
| if file_name != 'Item.h': | ||
| itemflag_helpers_check(file, file_path) | ||
| if file_name != 'ItemTemplate.h': | ||
| itemtemplateflag_helpers_check(file, file_path) | ||
| except UnicodeDecodeError: | ||
| print(f"\nCould not decode file {file_path}") | ||
| sys.exit(1) | ||
| # Output the results | ||
| print("") | ||
| for check, result in results.items(): | ||
| print(f"{check} : {result}") | ||
| if error_handler: | ||
| print("\nPlease fix the codestyle issues above.") | ||
| sys.exit(1) | ||
| else: | ||
| print(f"\nEverything looks good") | ||
|
|
||
| # Codestyle patterns checking for multiple blank lines | ||
| def multiple_blank_lines_check(file: io, file_path: str) -> None: | ||
| global error_handler, results | ||
| file.seek(0) # Reset file pointer to the beginning | ||
| check_failed = False | ||
| consecutive_blank_lines = 0 | ||
| # Parse all the file | ||
| for line_number, line in enumerate(file, start = 1): | ||
| if line.strip() == '': | ||
| consecutive_blank_lines += 1 | ||
| if consecutive_blank_lines > 1: | ||
| print(f"Multiple blank lines found in {file_path} at line {line_number - 1}") | ||
| check_failed = True | ||
| else: | ||
| consecutive_blank_lines = 0 | ||
| # Additional check for the end of the file | ||
| if consecutive_blank_lines >= 1: | ||
| print(f"Multiple blank lines found at the end of: {file_path}") | ||
| check_failed = True | ||
| # Handle the script error and update the result output | ||
| if check_failed: | ||
| error_handler = True | ||
| results["Multiple blank lines check"] = "Failed" | ||
|
|
||
| # Codestyle patterns checking for whitespace at the end of the lines | ||
| def trailing_whitespace_check(file: io, file_path: str) -> None: | ||
| global error_handler, results | ||
| file.seek(0) # Reset file pointer to the beginning | ||
| # Parse all the file | ||
| for line_number, line in enumerate(file, start = 1): | ||
| if line.endswith(' \n'): | ||
| print(f"Trailing whitespace found: {file_path} at line {line_number}") | ||
| if not error_handler: | ||
| error_handler = True | ||
| results["Trailing whitespace check"] = "Failed" | ||
|
|
||
| # Codestyle patterns checking for ObjectGuid::GetCounter() | ||
| def get_counter_check(file: io, file_path: str) -> None: | ||
| global error_handler, results | ||
| file.seek(0) # Reset file pointer to the beginning | ||
| # Parse all the file | ||
| for line_number, line in enumerate(file, start = 1): | ||
| if 'ObjectGuid::GetCounter()' in line: | ||
| print(f"Please use ObjectGuid::ToString().c_str() instead ObjectGuid::GetCounter(): {file_path} at line {line_number}") | ||
| if not error_handler: | ||
| error_handler = True | ||
| results["GetCounter() check"] = "Failed" | ||
|
|
||
| # Codestyle patterns checking for GetTypeId() | ||
| def get_typeid_check(file: io, file_path: str) -> None: | ||
| global error_handler, results | ||
| file.seek(0) # Reset file pointer to the beginning | ||
| check_failed = False | ||
| # Parse all the file | ||
| for line_number, line in enumerate(file, start = 1): | ||
| if 'GetTypeId() == TYPEID_ITEM' in line or 'GetTypeId() != TYPEID_ITEM' in line: | ||
| print(f"Please use IsItem() instead of GetTypeId(): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if 'GetTypeId() == TYPEID_UNIT' in line or 'GetTypeId() != TYPEID_UNIT' in line: | ||
| print(f"Please use IsCreature() instead of GetTypeId(): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if 'GetTypeId() == TYPEID_PLAYER' in line or 'GetTypeId() != TYPEID_PLAYER' in line: | ||
| print(f"Please use IsPlayer() instead of GetTypeId(): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if 'GetTypeId() == TYPEID_GAMEOBJECT' in line or 'GetTypeId() != TYPEID_GAMEOBJECT' in line: | ||
| print(f"Please use IsGameObject() instead of GetTypeId(): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if 'GetTypeId() == TYPEID_DYNOBJECT' in line or 'GetTypeId() != TYPEID_DYNOBJECT' in line: | ||
| print(f"Please use IsDynamicObject() instead of GetTypeId(): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| # Handle the script error and update the result output | ||
| if check_failed: | ||
| error_handler = True | ||
| results["GetTypeId() check"] = "Failed" | ||
|
|
||
| # Codestyle patterns checking for NpcFlag helpers | ||
| def npcflags_helpers_check(file: io, file_path: str) -> None: | ||
| global error_handler, results | ||
| file.seek(0) # Reset file pointer to the beginning | ||
| check_failed = False | ||
| # Parse all the file | ||
| for line_number, line in enumerate(file, start = 1): | ||
| if 'GetUInt32Value(UNIT_NPC_FLAGS)' in line: | ||
| print( | ||
| f"Please use GetNpcFlags() instead GetUInt32Value(UNIT_NPC_FLAGS): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if 'HasFlag(UNIT_NPC_FLAGS,' in line: | ||
| print( | ||
| f"Please use HasNpcFlag() instead HasFlag(UNIT_NPC_FLAGS, ...): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if 'SetUInt32Value(UNIT_NPC_FLAGS,' in line: | ||
| print( | ||
| f"Please use ReplaceAllNpcFlags() instead SetUInt32Value(UNIT_NPC_FLAGS, ...): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if 'SetFlag(UNIT_NPC_FLAGS,' in line: | ||
| print( | ||
| f"Please use SetNpcFlag() instead SetFlag(UNIT_NPC_FLAGS, ...): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if 'RemoveFlag(UNIT_NPC_FLAGS,' in line: | ||
| print( | ||
| f"Please use RemoveNpcFlag() instead RemoveFlag(UNIT_NPC_FLAGS, ...): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| # Handle the script error and update the result output | ||
| if check_failed: | ||
| error_handler = True | ||
| results["NpcFlagHelpers check"] = "Failed" | ||
|
|
||
| # Codestyle patterns checking for ItemFlag helpers | ||
| def itemflag_helpers_check(file: io, file_path: str) -> None: | ||
| global error_handler, results | ||
| file.seek(0) # Reset file pointer to the beginning | ||
| check_failed = False | ||
| # Parse all the file | ||
| for line_number, line in enumerate(file, start = 1): | ||
| if 'HasFlag(ITEM_FIELD_FLAGS, ITEM_FIELD_FLAG_REFUNDABLE)' in line: | ||
| print( | ||
| f"Please use IsRefundable() instead of HasFlag(ITEM_FIELD_FLAGS, ITEM_FIELD_FLAG_REFUNDABLE): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if 'HasFlag(ITEM_FIELD_FLAGS, ITEM_FIELD_FLAG_BOP_TRADEABLE)' in line: | ||
| print( | ||
| f"Please use IsBOPTradable() instead of HasFlag(ITEM_FIELD_FLAGS, ITEM_FIELD_FLAG_BOP_TRADEABLE): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if 'HasFlag(ITEM_FIELD_FLAGS, ITEM_FIELD_FLAG_WRAPPED)' in line: | ||
| print( | ||
| f"Please use IsWrapped() instead of HasFlag(ITEM_FIELD_FLAGS, ITEM_FIELD_FLAG_WRAPPED): {file_path} at line {line_number}") | ||
| check_failed = True | ||
| # Handle the script error and update the result output | ||
| if check_failed: | ||
| error_handler = True | ||
| results["ItemFlagHelpers check"] = "Failed" | ||
|
|
||
| # Codestyle patterns checking for ItemTemplate helpers | ||
| def itemtemplateflag_helpers_check(file: io, file_path: str) -> None: | ||
| global error_handler, results | ||
| file.seek(0) # Reset file pointer to the beginning | ||
| check_failed = False | ||
| # Parse all the file | ||
| for line_number, line in enumerate(file, start = 1): | ||
| if 'Flags & ITEM_FLAG' in line: | ||
| print( | ||
| f"Please use HasFlag(ItemFlag) instead of 'Flags & ITEM_FLAG_': {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if 'Flags2 & ITEM_FLAG2' in line: | ||
| print( | ||
| f"Please use HasFlag2(ItemFlag2) instead of 'Flags2 & ITEM_FLAG2_': {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if 'FlagsCu & ITEM_FLAGS_CU' in line: | ||
| print( | ||
| f"Please use HasFlagCu(ItemFlagsCustom) instead of 'FlagsCu & ITEM_FLAGS_CU_': {file_path} at line {line_number}") | ||
| check_failed = True | ||
| # Handle the script error and update the result output | ||
| if check_failed: | ||
| error_handler = True | ||
| results["ItemTemplateFlagHelpers check"] = "Failed" | ||
|
|
||
| # Codestyle patterns checking for various codestyle issues | ||
| def misc_codestyle_check(file: io, file_path: str) -> None: | ||
| global error_handler, results | ||
| file.seek(0) # Reset file pointer to the beginning | ||
| check_failed = False | ||
| # Parse all the file | ||
| for line_number, line in enumerate(file, start = 1): | ||
| if 'const auto&' in line: | ||
| print( | ||
| f"Please use 'auto const&' syntax instead of 'const auto&': {file_path} at line {line_number}") | ||
| check_failed = True | ||
| if re.search(r'\bconst\s+\w+\s*\*\b', line): | ||
| print( | ||
| f"Please use the syntax 'Class/ObjectType const*' instead of 'const Class/ObjectType*': {file_path} at line {line_number}") | ||
| check_failed = True | ||
| # Handle the script error and update the result output | ||
| if check_failed: | ||
| error_handler = True | ||
| results["Misc codestyle check"] = "Failed" | ||
|
|
||
| # Main function | ||
| parsing_file(src_directory) |
Oops, something went wrong.