feat(multiple rules): Do not sort unknown elements if unknown is not referenced in groups #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugop95
force-pushed
the
feat/no-unknown-sort
branch
3 times, most recently
from
c75beb7
to
92972d3
Compare
hugop95
force-pushed
the
feat/no-unknown-sort
branch
from
3188117
to
5d59c34
Compare
|
Could you fix merge conflicts? |
hugop95
force-pushed
the
feat/no-unknown-sort
branch
from
5d59c34
to
74dcebd
Compare
|
@azat-io Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The large majority of the actual code added involves documentation and tests.
Extends #220 to other rules that handle the
unknowngroup.When the
unknowngroup is not entered by the user in thegroupsoption,unknowngroup members will not be sorted and will remain where they are rather than go at the very bottom.sort-astro-attributessort-interfacessort-intersection-typessort-jsx-propssort-object-typessort-objectssort-svelte-attributessort-union-typessort-vue-attributesThe
sort-importsrule takes into account other complex elements such as newline separation, making it very different than other rules. Left for another PR if needed.Rules that had a default group configuration equal to
[]now have['unknown'](otherwise, they would not sort anything by default).Because all those rules rely on the same code to sort groups, a
sortNodesByGroupsfunction has been extracted, greatly reducing the amount of duplicate code.No existing unit test was impacted.
What is the purpose of this pull request?