fix(sort-classes): #268: ignored nodes prevent their adjacent node from triggering linting

[hugop95]

Description

Fixes #268.

When implementing the notion of ignored unknown group, ignored nodes were set to avoid creating linting errors: it's a bit counter-intuitive to tell the user that an ignored node should be before or after another node if it's supposed to be ignored.

Because linting errors are based on adjacent nodes comparison, classes that only have errors between ignored nodes and their adjacent nodes will not raise any error, and thus not trigger linting.

In practice, this likely shouldn't happen often and is fixed as soon as another error is detected in the class, as it will trigger linting and correctly sort it, so I don't believe this is a big issue (I detected it by accident while trying something else).

Custom groups with the unsorted sort type are unrelated to this issue. Only cases where a node has the unknown group may trigger this behavior.

This PR removes the checks that prevented errors from being raised between an ignored node and its adjacent nodes.

Because those ignored nodes now create ESLint error messages, a test had to be updated as it would now display more errors than before.

Possible improvements for another PR

class Class {
    b

    method() {
    }

    a
}

This PR will make the following errors appear:

• on method: Expected "method" (unknown) to come before "b" (property)
• on a: Expected "a" (property) to come before "method" (unknown)

The ideal message should appear only on a and say Expected "a" to come before "b".
The reasoning behind is that if we compute that a node N1 needs to be placed before an adjacent ignored node NI, then there is at least one other node N2 before NI that should be placed after N1.

What is the purpose of this pull request?

• Bug fix

[azat-io]

Could you fix merge conflicts?

[hugop95]

@azat-io Done!