merge: branch 'HoshinoTented-sameness'

aya-prover · Oct 30, 2023 · 5268637 · 5268637
2 parents ec3d867 + 538081b
commit 5268637
Show file tree

Hide file tree

Showing 3 changed files with 54 additions and 1 deletion.
diff --git a/src/main/kotlin/org/ice1000/kala/SamenessInspection.kt b/src/main/kotlin/org/ice1000/kala/SamenessInspection.kt
@@ -0,0 +1,47 @@
+package org.ice1000.kala
+
+import com.intellij.codeInspection.LocalQuickFix
+import com.intellij.codeInspection.ProblemDescriptor
+import com.intellij.codeInspection.ProblemHighlightType
+import com.intellij.codeInspection.ProblemsHolder
+import com.intellij.openapi.project.Project
+import com.intellij.psi.JavaPsiFacade
+import com.intellij.psi.PsiElementVisitor
+import com.intellij.psi.util.InheritanceUtil
+import com.siyeh.InspectionGadgetsBundle
+
+class SamenessInspection : KalaInspection() {
+  companion object {
+    private const val METHOD_NAME: String = "sameElements"
+  }
+
+  private object FIX : LocalQuickFix {
+    override fun getFamilyName(): String = InspectionGadgetsBundle.message("constant.conditional.expression.simplify.quickfix")
+
+    override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
+      descriptor.psiElement.replace(JavaPsiFacade.getElementFactory(project)
+        .createExpressionFromText("true", descriptor.endElement))
+    }
+  }
+
+  override fun getDisplayName(): String = InspectionGadgetsBundle.message("boolean.expression.can.be.simplified.problem.descriptor", "true")
+
+  override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor = methodCallVisitor {
+    val args = it.argumentList.expressions
+    val methodExpr = it.methodExpression
+    val selfExpr = methodExpr.qualifierExpression ?: return@methodCallVisitor
+    if (args.isEmpty()) return@methodCallVisitor
+    if (methodExpr.referenceName != METHOD_NAME) return@methodCallVisitor
+    val argExpr = args.first() ?: return@methodCallVisitor
+
+    val self = selfExpr.reference?.resolve() ?: return@methodCallVisitor
+    val arg = argExpr.reference?.resolve() ?: return@methodCallVisitor
+
+    if (InheritanceUtil.isInheritor(selfExpr.type, "$PKG.base.Traversable")
+      && self == arg) {
+      holder.registerProblem(holder.manager.createProblemDescriptor(
+        it, displayName, FIX, ProblemHighlightType.WARNING, isOnTheFly
+      ))
+    }
+  }
+}
diff --git a/src/main/kotlin/org/ice1000/kala/utils.kt b/src/main/kotlin/org/ice1000/kala/utils.kt
@@ -20,7 +20,8 @@ class KalaInspectionProvider : InspectionToolProvider {
     ViewSizeInspection::class.java,
     SizeCompareInspection::class.java,
     MapPutUnetaInspection::class.java,
-    ViewToMapInspection::class.java
+    ViewToMapInspection::class.java,
+    SamenessInspection::class.java
   )
 }
 

diff --git a/src/main/resources/inspectionDescriptions/Sameness.html b/src/main/resources/inspectionDescriptions/Sameness.html
@@ -0,0 +1,5 @@
+<html>
+<body>
+This inspection warns about comparing an <code>Traversable</code> with itself by <code>sameElements</code>.
+</body>
+</html>