Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial class related code #1106

Merged
merged 12 commits into from
Jun 9, 2024
Merged

Initial class related code #1106

merged 12 commits into from
Jun 9, 2024

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Jun 9, 2024

My proposed design on the concrete:

  1. ClazzDecl only has a telescope, it will never have result
  2. The telescope's local bindings are copied into a list of MemberVars
  3. The resolver should replace the local vars with MemberVars if there exists a corresponding one
  4. The tycker should deal with the self invocation

@ice1000 ice1000 added this to the v0.33 milestone Jun 9, 2024
@ice1000 ice1000 added the classes label Jun 9, 2024
@ice1000
Copy link
Member Author

ice1000 commented Jun 9, 2024

I expect this to drastically reduce coverage, in the next PR I'll try to add more tests to save some

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 55.43478% with 41 lines in your changes missing coverage. Please review.

Project coverage is 78.72%. Comparing base (aabbc82) to head (d4091bb).
Report is 1 commits behind head on main.

Files Patch % Lines
...x/src/main/java/org/aya/prettier/CorePrettier.java 27.27% 8 Missing ⚠️
.../java/org/aya/resolve/visitor/StmtPreResolver.java 0.00% 5 Missing ⚠️
...ain/java/org/aya/resolve/visitor/StmtResolver.java 50.00% 5 Missing ⚠️
...c/main/java/org/aya/compiler/ModuleSerializer.java 0.00% 4 Missing ⚠️
base/src/main/java/org/aya/tyck/StmtTycker.java 25.00% 2 Missing and 1 partial ⚠️
...er/src/main/java/org/aya/producer/AyaProducer.java 82.35% 0 Missing and 3 partials ⚠️
...rc/main/java/org/aya/syntax/core/def/ClassDef.java 0.00% 2 Missing ⚠️
...c/main/java/org/aya/syntax/core/def/MemberDef.java 0.00% 2 Missing ⚠️
.../main/java/org/aya/syntax/core/def/TyckAnyDef.java 0.00% 2 Missing ⚠️
...ax/src/main/java/org/aya/syntax/ref/MemberVar.java 66.66% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1106      +/-   ##
============================================
- Coverage     79.01%   78.72%   -0.29%     
- Complexity     3231     3237       +6     
============================================
  Files           294      298       +4     
  Lines          9828     9887      +59     
  Branches       1168     1172       +4     
============================================
+ Hits           7766     7784      +18     
- Misses         1416     1451      +35     
- Partials        646      652       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000 ice1000 merged commit 9bc1fe4 into main Jun 9, 2024
4 of 6 checks passed
@ice1000 ice1000 deleted the clazz branch June 9, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants