[Integ-test] Reduce sporadic failures from `test_slurm_memory_based_scheduling #6436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cheduling` Changed an error to warning because asserting job failures from insufficient memory is not the purpose of the test. Rather, the test purpose is, when memory based scheduling is disabled, the total requested memory of jobs on a node can surpass the total memory; when memory based scheduling is enabled, the jobs wait until previous jobs finish. When memory based scheduling is disabled, how operating systems handles two jobs requesting more memory than it has is not our concern. Signed-off-by: Hanwen <[email protected]>
hanwen-pcluste
added
the
skip-changelog-update
hgreebe
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed an error to warning because asserting job failures from insufficient memory is not the purpose of the test. Rather, the test purpose is: when memory based scheduling is disabled, the total requested memory of jobs on a node can surpass the total memory; when memory based scheduling is enabled, the jobs wait until previous jobs finish.
When memory based scheduling is disabled, how operating systems handle two jobs requesting more memory than it has is not our concern.
Tests
test_slurm_memory_based_schedulingpassed on alinux2, rhel8, ubuntu20Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.