Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAM policy elasticloadbalancing:DescribeTargetHealth #6427

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

hanwen-pcluste
Copy link
Contributor

This is necessary for pcluster describe-cluster to get healthy and unhealthy login nodes

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This is necessary for `pcluster describe-cluster` to get healthy and unhealthy login nodes

Signed-off-by: Hanwen <[email protected]>
@hanwen-pcluste hanwen-pcluste requested review from a team as code owners September 9, 2024 17:47
@hanwen-pcluste hanwen-pcluste added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Sep 9, 2024
@hanwen-pcluste hanwen-pcluste merged commit 0c71f5e into aws:develop Sep 9, 2024
28 of 29 checks passed
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (8641f35) to head (ffd4830).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6427      +/-   ##
===========================================
- Coverage    90.16%   90.14%   -0.03%     
===========================================
  Files          181      181              
  Lines        16059    16074      +15     
===========================================
+ Hits         14480    14490      +10     
- Misses        1579     1584       +5     
Flag Coverage Δ
unittests 90.14% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants