Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update retiring instances in integ tests #6419

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

dreambeyondorange
Copy link
Contributor

Also added mini config to ignore list

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dreambeyondorange dreambeyondorange added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Aug 28, 2024
@dreambeyondorange dreambeyondorange requested review from a team as code owners August 28, 2024 18:19
Copy link
Contributor

@hehe7318 hehe7318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (8641f35) to head (3e5785a).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6419   +/-   ##
========================================
  Coverage    90.16%   90.16%           
========================================
  Files          181      181           
  Lines        16059    16059           
========================================
  Hits         14480    14480           
  Misses        1579     1579           
Flag Coverage Δ
unittests 90.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreambeyondorange dreambeyondorange enabled auto-merge (squash) August 28, 2024 18:56
@dreambeyondorange dreambeyondorange merged commit e59f3f5 into aws:develop Aug 28, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants