Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Develop] Introduce pagnator in describe_images boto3 calls #6418

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Aug 28, 2024

Description of changes

  • Introduce pagnator in describe_images boto3 calls.

Tests

  • Pytest passed.
  • Manually test cluster creation passed.

References

  • This change can fix a potential issue of Cannot find official ParallelCluster AMI

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hehe7318 hehe7318 requested review from a team as code owners August 28, 2024 17:58
@hehe7318 hehe7318 added the 3.x label Aug 28, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
hanwen-pcluste
hanwen-pcluste previously approved these changes Aug 28, 2024
@hehe7318 hehe7318 merged commit 8edfdfa into aws:develop Aug 28, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants