Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integ-test] Fix build_image_custom_resource fixture #6400

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

hanwen-pcluste
Copy link
Contributor

Before this commit, instance_role_arn of another role could be returned just because the other role has the same role name prefix "dummyInstanceRole". This commit uses the complete role name to get the instance_role_arn

Tests

  • test_build_image has been passed

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Before this commit, `instance_role_arn` of another role could be returned just because the other role has the same role name prefix "dummyInstanceRole". This commit uses the complete role name to get the `instance_role_arn`

Signed-off-by: Hanwen <[email protected]>
@hanwen-pcluste hanwen-pcluste requested review from a team as code owners August 16, 2024 17:22
@hanwen-pcluste hanwen-pcluste added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Aug 16, 2024
@hanwen-pcluste hanwen-pcluste merged commit 6671b64 into aws:develop Aug 16, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants