Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the cluster stack name and cw log group name to the metadata table for quick identification #6385

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Add the cluster stack name and cw log group name to the metadata table for quick identification #6385

merged 1 commit into from
Aug 8, 2024

Conversation

dreambeyondorange
Copy link
Contributor

@dreambeyondorange dreambeyondorange commented Aug 7, 2024 •
edited
Loading

Tests

  • Tested changes locally on dev laptop, using dummy tests

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dreambeyondorange dreambeyondorange added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Aug 7, 2024
@dreambeyondorange dreambeyondorange requested review from a team as code owners August 7, 2024 23:53
@dreambeyondorange dreambeyondorange changed the title Add the cluster stack name to the metadata table for quick identifica… Add the cluster stack name and cw log group name to the metadata table for quick identifica… Aug 8, 2024
@dreambeyondorange dreambeyondorange changed the title Add the cluster stack name and cw log group name to the metadata table for quick identifica… Add the cluster stack name and cw log group name to the metadata table for quick identification Aug 8, 2024
hgreebe
hgreebe previously approved these changes Aug 8, 2024
View reviewed changes
@dreambeyondorange
Add the cluster stack name to the metadata table for quick identifica…
e3e4db8 
…tion

Also add the cw log group name as the stack name for now.  Adds a dummy cluster test for quick iteration as well.
@dreambeyondorange dreambeyondorange merged commit fb53c70 into aws:develop Aug 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgreebe hgreebe hgreebe approved these changes

Assignees
No one assigned
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreambeyondorange @hgreebe