Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Develop][Draft] Group test starccm and openfoam to share the same cluster #6321

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

[Develop][Draft] Group test starccm and openfoam to share the same cluster #6321

wants to merge 16 commits into from

Conversation

hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Jul 2, 2024

Description of changes

  • Group test starccm and openfoam to share the same cluster

Tests

  • Test failed, although use a module level scope fixture, two tests still run in separate clusters
  • By modify logging info and debug, seems tests are running in independent process and running at the same time, although they are in the same py file. They still can not call the same module level fixture.

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hehe7318 hehe7318 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Jul 2, 2024
@hehe7318 hehe7318 requested review from a team as code owners July 2, 2024 14:55
@hehe7318 hehe7318 force-pushed the wip/group-test-starccm-and-openfoam branch 2 times, most recently from 567b916 to 00ca668 Compare July 2, 2024 22:39
@hehe7318
Group test_starccm and openfoam, and improve logging message output
66c628b 
- Move duplicated codes to common file
- Modify two tests' config files to make sure they are the same and can be used by both tests
- Add dependencies.install.sh in openfoam testdir as well to avoid failures
- Create a new shared_performance_test_cluster fixture, to group two tests in the same stack
- Now, if openfoam and starccm are not installed, it will not log errors
- Now, when percentage_difference is 0, will log matching baseline message
@hehe7318
Change the shared_performance_test_cluster scope from session to class
8518d79
@hehe7318
Add shared fixture to test
84ba647
@hehe7318
Use shared fixture in shared cluster fixture for now to test, will mo…
e3210d6 
…dify in the future
@hehe7318
Restructure. Group two tests in a moudule, restructure files to adopt…
c5d5905 
… changes.
@hehe7318
Modify hasattr logic, add logging info to debug
ab38a35
@hehe7318
Delete dupicate errorexception
8634530
@hehe7318 hehe7318 force-pushed the wip/group-test-starccm-and-openfoam branch from 00ca668 to 8634530 Compare July 2, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hehe7318