changed the validation rules for DirectoryService.DomainName

[salemgolemugoo]

Description of changes

Loose the validation rules for DomainName option. For example JumpCloud LDAP provides DomainName in this form o=YOUR_ORG_ID,dc=jumpcloud,dc=com

Tests

Tested the regexp with regex101.com

References

https://jumpcloud.com/support/use-cloud-ldap

Checklist

• Make sure you are pointing to the right branch.
• If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
• Check all commits' messages are clear, describing what and why vs how.
• Make sure to have added unit tests or integration tests to cover the new/modified code.
• Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[enrico-usai]

Hi @salemgolemugoo,

thanks for your patch. Could you please extend the test_domain_name unit test in the cli/tests/pcluster/validators/test_directory_service_validators.py file to cover your new use case?

Then the patch can be merged!
Thanks again

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b99e3ed) 90.15% compared to head (4c98593) 90.15%.
Report is 12 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #5981   +/-   ##
========================================
  Coverage    90.15%   90.15%           
========================================
  Files          180      180           
  Lines        15742    15742           
========================================
  Hits         14192    14192           
  Misses        1550     1550           

Flag	Coverage Δ
unittests	90.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.