Consolidate ecs-eni plugin into vpc-eni plugin #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
reviewed
Jul 24, 2023
amogh09
reviewed
Jul 25, 2023
amogh09
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We currently maintain two ENI (Elastic Network Interface) plugins: ecs-eni in the amazon-ecs-cni-plugins repository, and vpc-eni in this repository. The former is for Linux whereas the latter is for Windows. Functionally they implement the exact same behavior used for VPC networking (a.k.a. awsvpc mode) in ECS.
This change merges the two plugins into one (vpc-eni) to eliminate parallel development and simplify deployments.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.