Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase prefix list entry limit to more than 1000 and fix bugs #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

douniwan5788
Copy link

No description provided.

@lazize
Copy link
Contributor

lazize commented Jul 2, 2024

What is the plan with >1000 prefix list?
How to use it inside a Security Group?

@douniwan5788
Copy link
Author

What is the plan with >1000 prefix list? How to use it inside a Security Group?

Many AWS services exceed 1000 CIDRs when combining several regions. Without this patch, the script will not function properly.

In fact, this patch distributes CIDRs exceeding 1000 across multiple prefix lists, each containing less than 1000 CIDRs. Security Groups are actually associated with ENIs (Elastic Network Interfaces), not instances. By associating these prefix lists with multiple Security Groups and subsequently with multiple ENIs, we can apply more than 1000 CIDRs to a single instance by binding multiple ENIs.

@lazize
Copy link
Contributor

lazize commented Jul 2, 2024

Correct, many exceed, it doesn't mean we need to allow and use all of them. At least not with Prefix List.

Following this logic, it means it will be required to expose all ENI's from this particular instance in order for it to be exposed and accept request from all IP range. So you can't expose the instance, you will need to expose the ENI IPs.
Which is not a best practice. We should expose ALB/NLB and not Instance or IPs from instance.

Please tell me a use case you need to use this to handle >1000 IP on Prefix List today. What is your requirement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants