Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recording frequency setting #12

Closed
wants to merge 1 commit into from

Conversation

sho-saito
Copy link

@sho-saito sho-saito commented Feb 4, 2024

NOTE: The changes in this PR are included in #13, so I closed this PR.

Issue #, if available:

#11

Description of changes:

Adding new option of recording frequency of CONTINUOUS and DAILY supported in recent update of AWS Config (https://aws.amazon.com/about-aws/whats-new/2023/11/aws-config-periodic-recording/)
This will help users of this solution choose from CONTINUOUS and DAILY by just selecting in CloudFormation parameter in order to reduce AWS config recording cost.

Thank you!

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sho-saito sho-saito marked this pull request as ready for review February 4, 2024 15:31
@drem-darios
Copy link

I really like this change, but it would require a lambda layer to update the default boto3 client used by Lambda. As of today, python3.12 uses boto3 1.28.72 which doesn't include the recordingMode parameter. https://boto3.amazonaws.com/v1/documentation/api/1.28.72/reference/services/config/client/put_configuration_recorder.html

@sho-saito
Copy link
Author

@drem-darios
Thank you for your comment!
And I saw the PR #13 you made. I learned a lot from it.
I think the PR should be merged in stead of this PR. So I think I take back this PR.

BTW, I appreciate that you mentioned me in the PR 👍

@sho-saito sho-saito closed this Mar 13, 2024
@sho-saito
Copy link
Author

sho-saito commented Apr 8, 2024

@drem-darios
I can't wait for the #13 to be merged. can't you? 😄

By the way, I just now noticed that you are mentioning different PR, not PR #12 but issue #5 in the PR #13.
If I am not mistaken and it's possible, could you please mention #12 in the PR #13 's description?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants