Add Ability to Cancel File upload from `processF… #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile` Adds ability to cancel uploads by throwing or rejecting the promise from `processFile.` Adds ability to react to/monitor errors with a new function and type * `onProcessFileError()` and `ProcessFileErrorParams` Changes: + adds new option user function `onProcessFileError()` to monitor errors + adds a new parameter type for the new function `ProcessFileErrorParams` * wraps `processFile in `resolveFile()` to handle the error safely + adds a usage example + adds tests * Updates Props list in the docs with the new method.
🦋 Changeset detectedLatest commit: d6e4d99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
|
@reesscot and @calebpollman |
…l-upload-from-process-file-v2
|
@reesscot @calebpollman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds support for the ability to cancel an Upload from
processFile()by returning a rejected promise.
Issue #, if available
#5099
Description of how you validated changes
removeUpload()is called when a rejected promise is returned fromprocessFile().Promise.reject()in examples.ran the example manually with additional Logging code
(not committed, and now removed to watch/verify operation.)
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Per @reesscot on #5179
I don't know a good way to easily squash and rebase my changes.
So I created a new branch from main and copied over the current version of that code instead.
CC: @calebpollman