Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: isolate js-frontend-config test #13615

Merged
merged 1 commit into from
Feb 23, 2024
Merged

chore: isolate js-frontend-config test #13615

merged 1 commit into from
Feb 23, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Feb 23, 2024

Description of changes

Fixes constant problem with the test by isolating it.
image

Issue #, if available

Description of how you validated changes

E2E and PR checks.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk marked this pull request as ready for review February 23, 2024 19:26
@sobolk sobolk requested a review from a team as a code owner February 23, 2024 19:26
@sobolk sobolk merged commit 8ad57bf into aws-amplify:dev Feb 23, 2024
5 of 6 checks passed
@sobolk sobolk deleted the isolate-that-test branch February 23, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardfoyle edwardfoyle edwardfoyle approved these changes

@awsluja awsluja awsluja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolk @edwardfoyle @awsluja