Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-internal): add DiagnoseReportUploadError status text #13163

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

0618
Copy link
Contributor

@0618 0618 commented Aug 28, 2023

Description of changes

Add error messages for DiagnoseReportUploadError to make the debugger easier.

Issue #, if available

#12913

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0618 0618 marked this pull request as ready for review August 28, 2023 22:35
@0618 0618 requested a review from a team as a code owner August 28, 2023 22:35
@@ -226,7 +226,7 @@ const sendFile = async (
body: data,
});
if (response.status !== 200) {
throw new DiagnoseReportUploadError();
throw new DiagnoseReportUploadError(response.statusText);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does it print ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants