fix: move importedModels key up to defineData

aws-amplify · Sep 26, 2024 · 663d474 · 663d474
1 parent 32edb50
commit 663d474
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/packages/amplify-gen2-codegen/src/data/source_builder.test.ts b/packages/amplify-gen2-codegen/src/data/source_builder.test.ts
@@ -27,5 +27,13 @@ describe('Data Category code generation', () => {
       const array = source.match(/importedModels:\s+\[(.*?)\]/);
       assert.deepEqual(tables, array?.[1].replaceAll('"', '').split(', '));
     });
+    it('has each each key in defineData', () => {
+      const tableMapping = { Todo: 'my-todo-mapping' };
+      const source = printNodeArray(generateDataSource({ tableMapping }));
+      assert.match(
+        source,
+        /defineData\({\n\s+importedAmplifyDynamoDBTableMap: \{\s+Todo: ['"]my-todo-mapping['"] },\n\s+importedModels:\s+\[.*?\],\n\s+schema: "TODO: Add your existing graphql schema here"\n}\)/,
+      );
+    });
   });
 });
diff --git a/packages/amplify-gen2-codegen/src/data/source_builder.ts b/packages/amplify-gen2-codegen/src/data/source_builder.ts
@@ -23,21 +23,21 @@ export const generateDataSource = (dataDefinition?: DataDefinition): ts.NodeArra
       tableMappingProperties.push(
         factory.createPropertyAssignment(factory.createIdentifier(tableName), factory.createStringLiteral(tableId)),
       );
-      tableMappingProperties.push(
-        factory.createPropertyAssignment(
-          factory.createIdentifier(importedModelsKey),
-          factory.createArrayLiteralExpression(
-            Object.keys(dataDefinition.tableMapping).map((tableName) => factory.createStringLiteral(tableName)),
-          ),
-        ),
-      );
     }
     dataRenderProperties.push(
       factory.createPropertyAssignment(
         importedAmplifyDynamoDBTableMapKeyName,
         factory.createObjectLiteralExpression(tableMappingProperties),
       ),
     );
+    dataRenderProperties.push(
+      factory.createPropertyAssignment(
+        importedModelsKey,
+        factory.createArrayLiteralExpression(
+          Object.keys(dataDefinition.tableMapping).map((tableName) => factory.createStringLiteral(tableName)),
+        ),
+      ),
+    );
   }
   dataRenderProperties.push(
     factory.createPropertyAssignment(factory.createIdentifier('schema'), factory.createStringLiteral(schemaPlaceholderComment)),