fix: lint, unit test, API.md

aws-amplify · Jul 31, 2024 · 2b7e9e8 · 2b7e9e8
1 parent edf400e
commit 2b7e9e8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/packages/amplify-graphql-model-transformer/API.md b/packages/amplify-graphql-model-transformer/API.md
@@ -168,6 +168,13 @@ export const getSsmEndpoint: (scope: Construct, resourceNames: SQLLambdaResource
 // @public (undocumented)
 export const getSubscriptionFilterInputName: (name: string) => string;
 
+// @public (undocumented)
+export const isSandboxDeployment: (context: TransformerContextProvider) => context is TransformerContextProvider & {
+    deploymentIdentifier: {
+        deploymentType: 'sandbox';
+    };
+};
+
 // @public (undocumented)
 export function makeAttributeTypeEnum(): EnumTypeDefinitionNode;
 

diff --git a/packages/amplify-graphql-model-transformer/src/__tests__/custom-resources.test.ts b/packages/amplify-graphql-model-transformer/src/__tests__/custom-resources.test.ts
@@ -45,7 +45,7 @@ describe('CustomResources', () => {
     const createProperties = JSON.parse(customResource.Properties.Create['Fn::Join'][1].join(''));
     const updateProperties = JSON.parse(customResource.Properties.Update['Fn::Join'][1].join(''));
 
-    const expectedPhysicalId = `TestLayerVersionCustomResource-${new Date().toISOString().substring(0, 10)}`;
+    const expectedPhysicalId = 'TestLayerVersionCustomResource';
     expect(createProperties.physicalResourceId.id).toEqual(expectedPhysicalId);
     expect(updateProperties.physicalResourceId.id).toEqual(expectedPhysicalId);
   });
@@ -67,7 +67,7 @@ describe('CustomResources', () => {
     const createProperties = JSON.parse(customResource.Properties.Create['Fn::Join'][1].join(''));
     const updateProperties = JSON.parse(customResource.Properties.Update['Fn::Join'][1].join(''));
 
-    const expectedPhysicalId = `TestSNSTopicARNCustomResource-${new Date().toISOString().substring(0, 10)}`;
+    const expectedPhysicalId = 'TestSNSTopicARNCustomResource';
     expect(createProperties.physicalResourceId.id).toEqual(expectedPhysicalId);
     expect(updateProperties.physicalResourceId.id).toEqual(expectedPhysicalId);
   });

diff --git a/packages/amplify-graphql-model-transformer/src/resolvers/rds/resolver.ts b/packages/amplify-graphql-model-transformer/src/resolvers/rds/resolver.ts
@@ -292,7 +292,7 @@ export const createSNSTopicARNCustomResource = (
 
 // Type predicate to check if the deployment type is 'sandbox'
 export const isSandboxDeployment = (
-  context: TransformerContextProvider
+  context: TransformerContextProvider,
 ): context is TransformerContextProvider & { deploymentIdentifier: { deploymentType: 'sandbox' } } => {
   return context?.synthParameters?.deploymentIdentifier?.deploymentType === 'sandbox';
 };