Windows line endings in scripts tests #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sobolk
reviewed
Sep 26, 2024
| @@ -353,7 +353,10 @@ void describe('Api usage generator', () => { | |||
| 'samplePackageName', | |||
| apiReportAST | |||
| ).generate(); | |||
| assert.strictEqual(apiUsage.trim(), testCase.expectedApiUsage.trim()); | |||
| assert.strictEqual( | |||
| apiUsage.replace(/[\r]/g, '').trim(), | |||
There was a problem hiding this comment.
mind adding a comment why are we doing this?
(presumably due to different EOL on windows).
sobolk
approved these changes
Sep 26, 2024
rtpascual
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Windows line endings (\r\n) would cause tests in
api_usage_generator.test.tsto fail because the expected output would differ from the actual output due to \r character.Issue number, if available:
Changes
\r characters are now replaced with empty strings in the actual output
Corresponding docs PR, if applicable:
Validation
tests are now passing on Windows
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.