Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call ret:emit_signal("timeout") instead of args.callback #3933

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

aarondill
Copy link
Contributor

This ensures that the timer gets passed on the first call of callback.
fixes: #3904

This ensures that the timer gets passed on the first call of callback.
fixes: awesomeWM#3904

Signed-off-by: aarondill <[email protected]>
Copy link
Member

@actionless actionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into it! 👍

@Elv13 Elv13 merged commit 220ae79 into awesomeWM:master Aug 18, 2024
9 checks passed
@aarondill aarondill deleted the gtimer-self branch August 18, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: gears.timer {call_now=true} doesn't pass self (ret)
4 participants