Add crop #3882
Merged
Add crop #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0acb3d4.
Co-authored-by: Lucas Schwiderski <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3882 +/- ##
==========================================
+ Coverage 90.99% 91.03% +0.03%
==========================================
Files 900 902 +2
Lines 57502 57714 +212
==========================================
+ Hits 52326 52540 +214
+ Misses 5176 5174 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
duxedo
pushed a commit
to duxedo/awesome
that referenced
this pull request
Mar 24, 2024
* added surface crop function * added busted tests * added devShell Flake * Revert "added devShell Flake" This reverts commit 0acb3d4. * general purpose crop added * cleanup * merged functions, added tests * replaced gdebug.print_error with error * clearer error message for crop Co-authored-by: Lucas Schwiderski <[email protected]> * make error message shorter * surface.crop: Fix doc warnings. --------- Co-authored-by: Paul Schneider <[email protected]> Co-authored-by: Paul Schneider <[email protected]> Co-authored-by: Lucas Schwiderski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #3776
Will merge as soon as tests pass.