Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWD2Parser ignores the "loop" property for SkeletonAnimation #707

Open
liaocheng opened this issue Sep 17, 2014 · 1 comment
Open

AWD2Parser ignores the "loop" property for SkeletonAnimation #707

liaocheng opened this issue Sep 17, 2014 · 1 comment

Comments

@liaocheng
Copy link
Member

See this code in parseSkeletonAnimation function:

 parseProperties(null); // Ignore properties for now

But the same process is done for VertexAnimation. See parseMeshPoseAnimation function:

props = parseProperties({1:BOOL, 2:BOOL});

clip.looping = props.get(1, true);
clip.stitchFinalFrame = props.get(2, false);

Should we add the same code to parseSkeletonAnimation as well?

@liaocheng liaocheng changed the title AWDencoder ignores the "loop" property for SkeletonAnimation AWD2Parser ignores the "loop" property for SkeletonAnimation Sep 17, 2014
@80prozent
Copy link
Contributor

Hey

Thank you for testing.
Yes. your suggestion is correct. The parsing of the properties should be the same for SkeleteonAnimation, as we have for MeshPoseAnimation.

I was used to commit to the dev-branch, but with the refactor for 4.1 going on, i will talk to Sergey/Rob which branch i should push fixes to (master-branch / 4.1Dev-branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants