-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snap package enablement #204
base: master
Are you sure you want to change the base?
Conversation
f1d8722
to
313ea87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this add Snap specific patch into the repository? Is PID == 0 something special in Snap? I think the check might use a configure time flag, but it should be in the upstream sources in final way. Not sure we can safely assume any process 0 cannot exist
I don't think it should be kept upstream. All this packaging stuff should be maintained by whoever ships snaps (by analogy with how for example Debian and Fedora maintain their packages). Let's close this. |
@lathiat I didn't know you were interested in this. Sorry! My reasoning was that to fully officially support snap (or any other way of packaging and deploying avahi) upstream it should be tested upstream in the sense that the CI should make sure that it can be built and deployed properly. It should be fixed upstream too. Without that it's just a bunch of files that make it look like it's supported upstream. (All in all I think downstreams with their testing infrastructures are usually much better at packaging stuff that works in their environments). |
Snapcraft is pushed hard by Ubuntu, they are planning to have everything serious in Snaps. Including system services like printing. In that way it is not just flatpak alternative. That was my impression from Ubuntu Summit in Prague. Not interesting to me as I think it belongs to the base system, but won't stop others preparing its proper support. |
It’s all good :) I’ll sort this one out. |
@evverx btw, don’t be afraid to close stuff generally. On the odd chance I want to do something different I’ll rescue it but probably won’t be many. |
@pemensik I think "proper" is the key word here. For example in its current form avahi is run with |
Before I forget I was curious so I installed avahi from https://snapcraft.io/avahi on Ubuntu (and I assume it's based on this PR more or less). It brings
but it comes without
All the methods can still be called directly:
but stuff relying on any sort of introspection doesn't work. I think it's a good example of a packaging issue that shouldn't be brought upstream. |
7512114
to
f4d6e2c
Compare
142e1f0
to
7973714
Compare
fffab0a
to
9f0c74f
Compare
70fae99
to
689938d
Compare
29b7cdf
to
1a8c89b
Compare
7d8dde8
to
2e1d9f2
Compare
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
First shot to upstream snap support