support running e2e_test.sh from any directory #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had been trying to run it as `../scripts/local/e2e_test.sh` from within the `contracts` dir, but it was failing to find the install scripts, and failing to find any ginkgo tests. With this change I can run it from that directory no problem.
feuGeneA
requested review from
iansuvak,
geoff-vball,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
geoff-vball
approved these changes
Sep 8, 2024
minghinmatthewlam
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
I had been trying to run it as
../scripts/local/e2e_test.shfrom within thecontractsdir, but it was failing to find the install scripts, and failing to find any ginkgo tests once I fixed those. With this change I can run it from that directory no problem.How this was tested
by running the script