Staking rewards #534
Merged
Staking rewards #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feuGeneA
force-pushed
the
staking-rewards
branch
4 times, most recently
from
737bf91
to
ea50cfb
Compare
feuGeneA
force-pushed
the
staking-rewards
branch
from
ea50cfb
to
2be2476
Compare
feuGeneA
force-pushed
the
staking-rewards
branch
3 times, most recently
from
3d67738
to
19d26be
Compare
feuGeneA
force-pushed
the
staking-rewards
branch
from
19d26be
to
318c277
Compare
feuGeneA
requested review from
iansuvak,
geoff-vball,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
addresses review comment #534 (comment)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
feuGeneA
force-pushed
the
staking-rewards
branch
from
236fee6
to
57a519e
Compare
iansuvak
reviewed
Sep 18, 2024
geoff-vball
requested review from
michaelkaplan13,
minghinmatthewlam and
iansuvak
geoff-vball
reviewed
Sep 19, 2024
| "PoSValidatorManager: delegation not pending added" | ||
| ); | ||
|
|
||
| // Update the delegator status | ||
| $._delegatorStakes[delegationID].status = DelegatorStatus.Completed; |
There was a problem hiding this comment.
I realized we don't actually need a DelegatorStatus.Completed since we can clear the delegator's state when we get to this stage. I can remove it from the enum if others thinks that makes sense
michaelkaplan13
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
for #489
How this was tested
via the unit tests herein