[testing] Fix image build validation for unmerged avalanchego commit #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
testing-image-build-for-unmerged-commit
branch
from
46a7671
to
5be3d84
Compare
marun
force-pushed
the
testing-image-build-for-unmerged-commit
branch
from
5be3d84
to
45e139b
Compare
marun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
#1318 added image build validation, but only included support for testing against published avalanchego versions. Since subnet-evm CI frequently needs to target unmerged avalanchego commits, this oversight can break CI for version bump PRs.
How this works
Updates the test to build the avalanchego image locally if it cannot be pulled. The logic that maintained the local avalanchego clone was extracted from the antithesis test script for reuse in the image build test script.
How this was tested
CI validates against regression, and the changes in this PR were validated by rebasing the changes against the latest bump PR that targets an unmerged avalanchego commit and confirming that the test still passed.
How is this documented
Code comments.