add pausable uptime manager #1340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
force-pushed
the
pausable-uptime-manager
branch
from
e156f9b
to
549d319
Compare
ceyonur
force-pushed
the
pausable-uptime-manager
branch
from
1520c18
to
0f16af2
Compare
darioush
reviewed
Sep 17, 2024
|
|
||
| var _ validators.StateCallbackListener = &pausableManager{} | ||
|
|
||
| var ErrPausedDc = errors.New("paused node cannot be disconnected") |
There was a problem hiding this comment.
let's avoid abbreviation of Disconnected to Dc
Comment on lines
61
to
62
| // We should never see this case | ||
| return ErrPausedDc |
There was a problem hiding this comment.
This error should not be triggered by calling exported functions if I understand correctly. (we can unexport it)
|
|
||
| // pause pauses uptime tracking for the node with the given ID | ||
| // pause can disconnect the node from the uptime.Manager if it is connected. | ||
| // Returns an error if the node is already paused. |
|
|
||
| // resume resumes uptime tracking for the node with the given ID | ||
| // resume can connect the node to the uptime.Manager if it was connected. | ||
| // Returns an error if the node is not paused. |
| currentTime = addTime(clk, 8*time.Second) | ||
| // Uptime should have increased by 8 seconds since the node was connected | ||
| checkUptime(t, up, nodeID0, 21*time.Second, currentTime) | ||
| } |
There was a problem hiding this comment.
I think we could improve this test using a table, may require some moving items around.
One approach could have callback fns like beforePause, afterPause etc
There was a problem hiding this comment.
some test cases require restart/reinitializing of manager. so not sure converting it to a table is a easy one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds pausable uptime manager interface for uptime tracking
How this works
Pausable uptime manager extends the avalanchego uptime manager by introducing callback listeners for validators state (under
plugin/evm/validators). The idea is to pause a node's uptime and then can continue whenever it's resumed. It also modifiesConnect,Disconnect,StartTracking` accordingly.How this was tested
Added tests
How is this documented
Comments in code