Move state layout to options #1204
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
commented
Jul 26, 2024
| @@ -158,6 +165,9 @@ func New( | |||
| // Set defaults | |||
| vm.builder = builder.NewTime(vm) | |||
| vm.gossiper = txGossiper | |||
| vm.heightKey = []byte("height") | |||
| vm.timestampKey = []byte("timestamp") | |||
| vm.feeKey = []byte("fee") | |||
There was a problem hiding this comment.
todo we might introduce hypersdk keys that conflict w/ the controller's keys so it would be good to have a way to detect conflicts in the implementation side during initialization
There was a problem hiding this comment.
Alternatively, we could make the default to prefix the HyperSDK metadata and have a separate prefix for standard VM implementations portion of state.
There was a problem hiding this comment.
Another idea is to have an entirely separate state db for hypersdk defined state vs for state the controller defines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.