Rewrite of parts of the #[public] macro
#1193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iFrostizz
changed the title
#[public] macro
iFrostizz
requested review from
dboehm-avalabs,
richardpringle and
samliok
as code owners
iFrostizz
commented
Jul 25, 2024
Comment on lines
+33
to
+41
| // pass parameter if ignored with underscore | ||
| if matches!(*pat_type.pat, Pat::Wild(_)) { | ||
| pat_type.pat = Box::new(Pat::Ident(PatIdent { | ||
| attrs: vec![], | ||
| by_ref: None, | ||
| mutability: None, | ||
| ident: Ident::new("_ctx", Span::call_site()), | ||
| subpat: None, | ||
| })) |
There was a problem hiding this comment.
This is now needed because the parameters are all user-defined. Meaning that the context that used to be param_0 as expected could also be a wildcard _ and this parameter cannot be passed around.
Now the issue is that this is going to fail if any other parameter is named _ctx such as with this function signature:
#[public]
pub fn inc(_: Context, _ctx: Context, external: Program, address: Address)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1183
Copy parameters in bindings definition:
The parameter names used to be
param_0,param_1, ...The original parameter names have been copied to have better docs and LSP support.
You can verify this with
cargo doc -p counter -F bindings --openAs part of this, much of the code could be simplified further