Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: perform eth_sendTransaction via EVM module #51

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Sep 20, 2024

  • CP-9159
  • + migrate eth_sendTransaction to be performed via EVM Module

TODOs

  • Make sure custom chainId behavior is the same
    • no cross-environment transaction execution allowed (no mainnet execution while UI is on testnet or vice-versa)
    • transactions on custom networks are only allowed if the custom network is also active in the UI

Changes

  • Starts using the updateTx callback provided by VM Modules for updating transaction fee configs / spend limits (see related PR above)
  • Removes eth_sendTransaction handler and some of the related files so that those requests are performed using the EvmModule
    • Also removes the SignTransaction.tsx file / route & related files
  • Updates useFeeCustomizer hook to also handle EVM fees
  • Updates approval screen components to the new displayData schema so they can be used on GenericApprovalScreen

Testing

Basically a full regression on EVM features is needed:

  • Send
  • Bridge
  • Swap
    • all of the above features but initiated by Core Web
  • Send NFT
  • dApp integrations (i.e. liquidity pool on TraderJoe.xyz)
    • make sure token spend approvals work as they used to

Screenshots:

TBA

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant