Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CP-9166 add tooltip and disabled button #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vvava
Copy link
Contributor

@vvava vvava commented Sep 16, 2024

Description

We want to prevent the user clicks the save button if there is an error in the form and indicate that somewhere.

Changes

The Save button is disabled until the form is valid and there is a tooltip on that to indicate there is some errors in the form.

Testing

Go to Add custom network -> try the form out with correct and wrong values.

Screenshots:

Screen.Recording.2024-09-16.at.18.17.52.mov

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants