Relay supported fee assets #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cam-schultz do we want to close this draft as wellf or now, and revisit as it's picked back up? |
This is still a candidate change, so let's leave it open. |
There was a problem hiding this comment.
High level LGTM, should be similar to #59 in terms of allowing specific fields, otherwise allow all. Will re-review after it's updated with latest changes, some of the abi packing/unpacking might look different with Teleporter pkg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Teleporter configuration option for supported fee assets. The relayer will only deliver a message if it is incentivized with a supported fee asset, or if the configured list of fee assets is empty.
In addition to that check, the main change here is adding an additional eth client in the Teleporter message manager, so that we can call getFeeInfo on the Teleporter contract. The message manager constructor takes the source subnet configuration to do so.