Genesis icm #2154
Open
Genesis icm #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipemadero
requested review from
sukantoraymond and
arturrez
and removed request for
a team
arturrez
reviewed
Sep 19, 2024
arturrez
reviewed
Sep 19, 2024
arturrez
reviewed
Sep 19, 2024
arturrez
reviewed
Sep 19, 2024
arturrez
reviewed
Sep 19, 2024
Comment on lines
+280
to
+285
| if len(allocation.Code) > 0 { | ||
| continue | ||
| } | ||
| if address == common.HexToAddress(icmgenesis.MessengerDeployerAddress) { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Why do we skip the deployer address and any allocation with code here? Could be helpful to add a comment explaining
| @@ -235,3 +235,39 @@ func GetEVMSubnetGenesisNativeMinterAdmin( | |||
| } | |||
| return getGenesisNativeMinterAdmin(app, network, genesisData) | |||
| } | |||
|
|
|||
| func ContractAddressIsInBlockchainGenesis( | |||
There was a problem hiding this comment.
Could we add unit tests for these two new functions?
| return nil | ||
| } | ||
|
|
||
| func ICMAtBlockchainGenesis( |
There was a problem hiding this comment.
Could you add comments documenting what these new functions are and how they are intended to be used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2142
Setups icm and registry in subnet-vm genesis.