Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ring outlier filter and distortion correction node load from param file #6

Conversation

Aysenayilmaz
Copy link

@Aysenayilmaz Aysenayilmaz commented Oct 1, 2024

Description

PR autowarefoundation/autoware.universe#8468 removes the default parameter, thus common_sensor_launch needs to load the ring outlier parameter from the parameter file.

Related links

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx changed the title feat : ring outlier filter load from param file feat: ring outlier filter load from param file Oct 1, 2024
Signed-off-by: A. Sena Yılmaz <[email protected]>
@maxime-clem
Copy link

Thank you for preparing this fix.
I tested it and it fixes the undefined parameter issue, but I run into other issues with the LIDAR topics:

[component_container-32] [ERROR] [1727833418.956313853] [sensing.lidar.left.ring_outlier_filter]: [convert_output_costly] Error converting output dataset from base_link to lidar.
[component_container-32] [ERROR] [1727833418.957365214] [sensing.lidar.left.distortion_corrector_node]: The pointcloud layout is not compatible with PointXYZIRCAEDT. Aborting
[autoware_ekf_localizer_node-41] [WARN] [1727833419.527597148] [localization.pose_twist_fusion_filter.ekf_localizer]: The node is not activated. Provide initial pose to pose_initializer
[component_container-33] [WARN] [1727833419.631621728] [sensing.lidar.right.ring_outlier_filter]: failed to get transform from lidar to base_link: "lidar" passed to lookupTransform argument target_frame does not exist. 
[component_container-33] [ERROR] [1727833419.631664637] [sensing.lidar.right.ring_outlier_filter]: [convert_output_costly] Error converting output dataset from base_link to lidar.
[component_container-33] [ERROR] [1727833419.631698735] [sensing.lidar.right.distortion_corrector_node]: The pointcloud layout is not compatible with PointXYZIRCAEDT. Aborting
[component_container-31] [WARN] [1727833419.739107896] [sensing.lidar.top.ring_outlier_filter]: failed to get transform from lidar to base_link: "lidar" passed to lookupTransform argument target_frame does not exist. 
[component_container-31] [ERROR] [1727833419.739173112] [sensing.lidar.top.ring_outlier_filter]: [convert_output_costly] Error converting output dataset from base_link to lidar.
[component_container-31] [ERROR] [1727833419.740276821] [sensing.lidar.top.distortion_corrector_node]: The pointcloud layout is not compatible with PointXYZIRCAEDT. Aborting
[component_container-32] [WARN] [1727833420.006367465] [sensing.lidar.left.ring_outlier_filter]: failed to get transform from lidar to base_link: "lidar" passed to lookupTransform argument target_frame does not exist. 
[component_container-32] [ERROR] [1727833420.006461553] [sensing.lidar.left.ring_outlier_filter]: [convert_output_costly] Error converting output dataset from base_link to lidar.
[component_container-32] [ERROR] [1727833420.007616301] [sensing.lidar.left.distortion_corrector_node]: The pointcloud layout is not compatible with PointXYZIRCAEDT. Aborting

This is with awsim_labs_v1.5.1, the latest Autoware, and using this PR for awsim_labs_sensor_kit_launch.

Signed-off-by: A. Sena Yılmaz <[email protected]>
@Aysenayilmaz Aysenayilmaz marked this pull request as ready for review October 2, 2024 08:56
@Aysenayilmaz Aysenayilmaz changed the title feat: ring outlier filter load from param file feat: ring outlier filter and distortion correction node load from param file Oct 2, 2024
@xmfcx xmfcx self-requested a review October 2, 2024 09:09
Copy link

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, with these changes it is localizing and driving again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants