Skip to content

Commit

Permalink
fix ring outlier filter node
Browse files Browse the repository at this point in the history
Signed-off-by: A. Sena Yılmaz <[email protected]>
  • Loading branch information
Aysenayilmaz committed Oct 2, 2024
1 parent 5bce945 commit 993f3a5
Showing 1 changed file with 5 additions and 31 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@ def create_parameter_dict(*args):
)

# Ring Outlier Filter is the last component in the pipeline, so control the output frame here
if LaunchConfiguration("output_as_sensor_frame").perform(context).lower() == "true":
ring_outlier_output_frame = {"output_frame": LaunchConfiguration("frame_id")}
else:
ring_outlier_output_frame = {"output_frame": ""} # keep the output frame as the input frame
# if LaunchConfiguration("output_as_sensor_frame").perform(context).lower() == "true":
# ring_outlier_output_frame = {"output_frame": LaunchConfiguration("frame_id")}
# else:
# ring_outlier_output_frame = {"output_frame": ""} # keep the output frame as the input frame
nodes.append(
ComposableNode(
package="autoware_pointcloud_preprocessor",
Expand All @@ -154,7 +154,7 @@ def create_parameter_dict(*args):
("input", "rectified/pointcloud_ex"),
("output", "pointcloud_before_sync"),
],
parameters=[ring_outlier_filter_node_param, ring_outlier_output_frame],
parameters=[ring_outlier_filter_node_param],
extra_arguments=[{"use_intra_process_comms": LaunchConfiguration("use_intra_process")}],
)
)
Expand All @@ -170,32 +170,6 @@ def create_parameter_dict(*args):
output="both",
)

# distortion_relay_component = ComposableNode(
# package="topic_tools",
# plugin="topic_tools::RelayNode",
# name="pointcloud_distortion_relay",
# namespace="",
# parameters=[
# {"input_topic": "mirror_cropped/pointcloud_ex"},
# {"output_topic": "rectified/pointcloud_ex"}
# ],
# extra_arguments=[{"use_intra_process_comms": LaunchConfiguration("use_intra_process")}],
# )

# one way to add a ComposableNode conditional on a launch argument to a
# container. The `ComposableNode` itself doesn't accept a condition
# distortion_loader = LoadComposableNodes(
# composable_node_descriptions=[distortion_component],
# target_container=container,
# condition=launch.conditions.IfCondition(LaunchConfiguration("use_distortion_corrector")),
# )
# distortion_relay_loader = LoadComposableNodes(
# composable_node_descriptions=[distortion_relay_component],
# target_container=container,
# condition=launch.conditions.UnlessCondition(LaunchConfiguration("use_distortion_corrector")),
# )
# return [container, distortion_loader, distortion_relay_loader]

return [container]


Expand Down

0 comments on commit 993f3a5

Please sign in to comment.