fix(dynamic_obstacle_avoidance): improve avoidance for moving NPCs #1170
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyzanurkaya
requested review from
takayuki5168,
rej55,
satoshi-ota,
shmpwk,
danielsanchezaran,
kyoichi-sugahara,
zulfaqar-azmi-t4,
go-sakayori,
kosuke55,
mkquda,
maxime-clem,
soblin,
yhisaki and
yuki-takagi-66
as code owners
beyzanurkaya
added
the
component:planning
github-actions
bot
removed
the
component:planning
brkay54
pushed a commit
that referenced
this pull request
Sep 18, 2024
…rban scenarios #1170 Signed-off-by: beyza <[email protected]>
beyzanurkaya
force-pushed
the
fix-dynamic-obstacle-avoidance-for-dense-urban-odd
branch
from
10c95fa
to
1b7f738
Compare
beyzanurkaya
added
component:planning
6 tasks
beyzanurkaya
force-pushed
the
fix-dynamic-obstacle-avoidance-for-dense-urban-odd
branch
from
1b7f738
to
ed273a0
Compare
github-actions
bot
removed
the
component:planning
beyzanurkaya
force-pushed
the
fix-dynamic-obstacle-avoidance-for-dense-urban-odd
branch
from
ed273a0
to
f060c23
Compare
brkay54
added a commit
that referenced
this pull request
Sep 30, 2024
…urban scenarios Signed-off-by: beyza <[email protected]> #1170
beyzanurkaya
force-pushed
the
fix-dynamic-obstacle-avoidance-for-dense-urban-odd
branch
3 times, most recently
from
0f7a87d
to
7e2063d
Compare
brkay54
added a commit
that referenced
this pull request
Oct 1, 2024
…urban scenarios Signed-off-by: beyza <[email protected]> #1170
brkay54
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
With this PR, dynamic avoidance related scenarios have passed: AWF_Test_Report
…urban scenarios Signed-off-by: beyza <[email protected]>
…o handle dense urban scenarios Signed-off-by: beyza <[email protected]>
beyzanurkaya
force-pushed
the
fix-dynamic-obstacle-avoidance-for-dense-urban-odd
branch
from
7e2063d
to
c7713ab
Compare
|
@takayuki5168 san, could you check this PR when you are available or can you assign someone to review? |
Thank you for comment @yuki-takagi-66 -san. Is this comment valid for all 3 modified values or do you have doubts about any of them specifically? |
|
In this scenario, NPC's velocity is 40 km/h but still passing 2024-10-02.16-09-00.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes :
Related links
Parent Issue :
Tests performed
when dynamic_obstacle_avoidance is enable
NTR-002-0001-case1.-.Passed.all.cases.mp4
NTR-002-0001-case2.-.Passed.all.cases.mp4
Interface changes
ROS Parameter Changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.